Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqPackages_8_19.coqhammer: init #320697

Closed
wants to merge 1 commit into from

Conversation

CohenCyril
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vbgl
Copy link
Contributor

vbgl commented Jun 18, 2024

Does this build? IIRC, the upstream build-system is broken and the package should be split into tactics & plugin.

@CohenCyril
Copy link
Contributor Author

Does this build? IIRC, the upstream build-system is broken and the package should be split into tactics & plugin.

The answer, which you knew, is it does not build.

@CohenCyril CohenCyril marked this pull request as draft June 20, 2024 10:08
@vbgl vbgl mentioned this pull request Jun 26, 2024
13 tasks
@vbgl vbgl closed this in #322601 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants