-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnomeExtensions.open-bar: init at unstable-2024-06-17 #320626
base: master
Are you sure you want to change the base?
Conversation
9737c33
to
51f19ac
Compare
Note that we have it already packaged by the automatic import from e.g.o: https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/gnome/extensions/README.md Is there a specific reason you need an unstable version? |
@jtojnar when I attempted to use it, I ran into this issue: neuromorph/openbar#38 Once I have it in a functional state, I'll be happy to rework this to update the current package and would appreciate feedback on how to actually implement that (the nixpkgs GNOME extension documentation was really not clear to me -- which is why I'm probably doing it incorrectly). |
5477d68
to
b947a67
Compare
@jtojnar I can confirm my latest commit fixes the issue I linked above. Please let me know how I should organize this correctly and I will do what is needed. 👍 |
This technically still has one other issue that I think should be addressed before this is considered ready, that I outlined in this comment: neuromorph/openbar#38 (comment) The issue is that the files this extension generates are all created with I also need to add my commit to add myself as a maintainer. |
I tested using the latest commit on the nixfix branch of open bar and it works correctly so far. I think the branch is on the active development path though and has quite a few bugs. Once it is merged in though, the auto packaging should be sufficient. |
Latest main branch of open-bar works properly for me! @jtojnar it seems like the best thing would be for me to back out this PR and revert back to nixpkgs' automatic updating of GNOME extensions. Or maybe I can repurpose this PR to update all the extensions to the latest version? What would you suggest would be the best path forward for getting the latest working version of openbar added to nixpkgs? |
If the release comes soon, you can update all extensions. Probably better to open a new PR for that. |
If the custom packaging doesn’t add any extra value maybe it’s better to remove it, then it’s less stuff to maintain, right? |
Description of changes
Adds openbar GNOME extension
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.