Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.open-bar: init at unstable-2024-06-17 #320626

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heywoodlh
Copy link
Contributor

@heywoodlh heywoodlh commented Jun 17, 2024

Description of changes

Adds openbar GNOME extension

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jtojnar
Copy link
Member

jtojnar commented Jun 20, 2024

Note that we have it already packaged by the automatic import from e.g.o: https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/gnome/extensions/README.md

Is there a specific reason you need an unstable version?

@heywoodlh
Copy link
Contributor Author

@jtojnar when I attempted to use it, I ran into this issue: neuromorph/openbar#38

Once I have it in a functional state, I'll be happy to rework this to update the current package and would appreciate feedback on how to actually implement that (the nixpkgs GNOME extension documentation was really not clear to me -- which is why I'm probably doing it incorrectly).

@heywoodlh heywoodlh force-pushed the openbar-init branch 2 times, most recently from 5477d68 to b947a67 Compare June 24, 2024 23:42
@heywoodlh
Copy link
Contributor Author

@jtojnar I can confirm my latest commit fixes the issue I linked above.

Please let me know how I should organize this correctly and I will do what is needed. 👍

@heywoodlh heywoodlh marked this pull request as ready for review June 24, 2024 23:55
@heywoodlh
Copy link
Contributor Author

This technically still has one other issue that I think should be addressed before this is considered ready, that I outlined in this comment: neuromorph/openbar#38 (comment)

The issue is that the files this extension generates are all created with 444 permissions, which causes the extension to not turn back on if you turn it off and try to turn it back on.

I also need to add my commit to add myself as a maintainer.

@balintbarna
Copy link

I tested using the latest commit on the nixfix branch of open bar and it works correctly so far. I think the branch is on the active development path though and has quite a few bugs. Once it is merged in though, the auto packaging should be sufficient.

@heywoodlh
Copy link
Contributor Author

Latest main branch of open-bar works properly for me!

@jtojnar it seems like the best thing would be for me to back out this PR and revert back to nixpkgs' automatic updating of GNOME extensions. Or maybe I can repurpose this PR to update all the extensions to the latest version?

What would you suggest would be the best path forward for getting the latest working version of openbar added to nixpkgs?

@jtojnar
Copy link
Member

jtojnar commented Jul 1, 2024

If the release comes soon, you can update all extensions.

Probably better to open a new PR for that.

@balintbarna
Copy link

If the custom packaging doesn’t add any extra value maybe it’s better to remove it, then it’s less stuff to maintain, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants