-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libhwy: 1.0.7 -> 1.2.0 #320616
base: staging
Are you sure you want to change the base?
libhwy: 1.0.7 -> 1.2.0 #320616
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4305 |
@ofborg build libhwy |
aarch64-linux fails to build
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The riscv patch need an update:
diff --git a/pkgs/development/libraries/libhwy/default.nix b/pkgs/development/libraries/libhwy/default.nix
index c82d3738efe9..c5a777be8691 100644
--- a/pkgs/development/libraries/libhwy/default.nix
+++ b/pkgs/development/libraries/libhwy/default.nix
@@ -18,14 +18,13 @@ stdenv.mkDerivation rec {
hash = "sha256-yJQH5ZkpEdJ6lsTAt6yJSN3TQnVoxNpkbChENaxhcHo=";
};
- patches = lib.optional stdenv.hostPlatform.isRiscV
- # Adds CMake option HWY_CMAKE_RVV
- # https://github.com/google/highway/pull/1743
+ patches = [
(fetchpatch {
- name = "libhwy-add-rvv-optout.patch";
- url = "https://github.com/google/highway/commit/5d58d233fbcec0c6a39df8186a877329147324b3.patch";
- hash = "sha256-ileSNYddOt1F5rooRB0fXT20WkVlnG+gP5w7qJdBuww=";
- });
+ name = "disable-RVV-runtime-dispatch.patch";
+ url = "https://github.com/google/highway/commit/c95cc0237d2f7a0f5ca5dc3fb4b5961b2b1dcdfc.patch";
+ hash = "sha256-oQfyZrjZ9MGcSrFInbbj+0iOLjPng7tgTzli1QTITSg=";
+ })
+ ];
hardeningDisable = lib.optionals stdenv.hostPlatform.isAarch64 [
# aarch64-specific code gets:
Applied. Thank you! |
that still doesn't work... |
Yeah, I did not get to look at it. Let's convert to draft. |
Changes:
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.