Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio: add udev to dependencies #320613

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

yottanami
Copy link
Contributor

Description of changes

This PR addresses an issue with the PlatformIO package for the Teensy 4.1 board on NixOS. The error encountered during the upload process is caused by the teensy_reboot tool, which requires the libudev.so.1 shared library. This library is not included by default in the PlatformIO package on NixOS, leading to a failure when attempting to upload code to the Teensy device.

To resolve this, the package's chrootenv.nix has been edited to include udev, ensuring that libudev.so.1 is available during the upload process. This change allows the teensy-cli and teensy-reboot binaries to function correctly in the NixOS environment.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mindavi Mindavi merged commit 7e1f4f7 into NixOS:master Jun 19, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants