Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn2nix: avoid appearing to include src #320578

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

philiptaron
Copy link
Contributor

Description of changes

This expression didn't actually include src, but it looked like it did. Make it like others by using a fileset (for instance, #319883)

I verified that this didn't do anything by diffing the two derivation and seeing no difference.

diff -r -u4 /nix/store/sf2zmfydysqpk38nwa84yv41hcprby6m-yarn2nix /nix/store/wlvsdkmglkq6n63akvnhg929rllxwv68-source

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This expression didn't actually include src, but it looked like it did.
Make it like others by using a fileset (for instance, NixOS#319883)
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to see the kind of mess we can avoid with lib.fileset :D

@infinisil infinisil merged commit 96b134d into NixOS:master Jun 17, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants