Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.qcodes: 0.44.1 -> 0.45.0 #320532

Merged
merged 2 commits into from
Jun 18, 2024
Merged

python311Packages.qcodes: 0.44.1 -> 0.45.0 #320532

merged 2 commits into from
Jun 18, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jun 17, 2024 •
edited

Description of changes

Changelog: https://github.com/QCoDeS/Qcodes/releases/tag/v0.45.0

cc @evilmav

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 320532 run on aarch64-linux 1

8 packages built:
  • python311Packages.qcodes
  • python311Packages.qcodes-contrib-drivers
  • python311Packages.qcodes-contrib-drivers.dist
  • python311Packages.qcodes.dist
  • python312Packages.qcodes
  • python312Packages.qcodes-contrib-drivers
  • python312Packages.qcodes-contrib-drivers.dist
  • python312Packages.qcodes.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 320532 run on aarch64-darwin 1

8 packages built:
  • python311Packages.qcodes
  • python311Packages.qcodes-contrib-drivers
  • python311Packages.qcodes-contrib-drivers.dist
  • python311Packages.qcodes.dist
  • python312Packages.qcodes
  • python312Packages.qcodes-contrib-drivers
  • python312Packages.qcodes-contrib-drivers.dist
  • python312Packages.qcodes.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 320532 run on x86_64-linux 1

8 packages built:
  • python311Packages.qcodes
  • python311Packages.qcodes-contrib-drivers
  • python311Packages.qcodes-contrib-drivers.dist
  • python311Packages.qcodes.dist
  • python312Packages.qcodes
  • python312Packages.qcodes-contrib-drivers
  • python312Packages.qcodes-contrib-drivers.dist
  • python312Packages.qcodes.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 320532 run on x86_64-darwin 1

8 packages built:
  • python311Packages.qcodes
  • python311Packages.qcodes-contrib-drivers
  • python311Packages.qcodes-contrib-drivers.dist
  • python311Packages.qcodes.dist
  • python312Packages.qcodes
  • python312Packages.qcodes-contrib-drivers
  • python312Packages.qcodes-contrib-drivers.dist
  • python312Packages.qcodes.dist

natsukium
natsukium reviewed Jun 18, 2024
View reviewed changes
pkgs/development/python-modules/qcodes/default.nix
Comment on lines -82 to -83
opencensus
opencensus-ext-azure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add these dependencies to optional-dependencies?
microsoft/Qcodes@refs/tags/v0.44.1...v0.45.0#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (along other optional dependencies).

natsukium
natsukium reviewed Jun 18, 2024
View reviewed changes
pkgs/development/python-modules/qcodes/default.nix Outdated
@@ -97,6 +109,34 @@ buildPythonPackage rec {
xarray
] ++ lib.optionals (pythonOlder "3.10") [ importlib-metadata ];

passthru.optional-dependencies = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
passthru.optional-dependencies = {
optional-dependencies = {

We no longer need passthru.
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#buildpythonpackage-parameters-buildpythonpackage-parameters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right ! Removed.

natsukium
natsukium approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit 7ec4401 into NixOS:master Jun 18, 2024
23 of 24 checks passed
@GaetanLepage GaetanLepage deleted the qcodes branch June 18, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@SomeoneSerge SomeoneSerge Awaiting requested review from SomeoneSerge

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GaetanLepage @natsukium