-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.qcodes: 0.44.1 -> 0.45.0 #320532
Conversation
Result of 8 packages built:
|
Result of 8 packages built:
|
Result of 8 packages built:
|
Result of 8 packages built:
|
opencensus | ||
opencensus-ext-azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add these dependencies to optional-dependencies
?
microsoft/Qcodes@refs/tags/v0.44.1...v0.45.0#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (along other optional dependencies).
@@ -97,6 +109,34 @@ buildPythonPackage rec { | |||
xarray | |||
] ++ lib.optionals (pythonOlder "3.10") [ importlib-metadata ]; | |||
|
|||
passthru.optional-dependencies = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passthru.optional-dependencies = { | |
optional-dependencies = { |
We no longer need passthru
.
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#buildpythonpackage-parameters-buildpythonpackage-parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right ! Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Description of changes
Changelog: https://github.com/QCoDeS/Qcodes/releases/tag/v0.45.0
cc @evilmav
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.