Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marp-cli: 3.2.0 -> 3.4.0 #320354

Merged
merged 1 commit into from
Jun 19, 2024
Merged

marp-cli: 3.2.0 -> 3.4.0 #320354

merged 1 commit into from
Jun 19, 2024

Conversation

marcusramberg
Copy link
Contributor

@marcusramberg marcusramberg commented Jun 16, 2024

Description of changes

Changelog: https://github.com/marp-team/marp-cli/releases

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@marcusramberg
Copy link
Contributor Author

@GuillaumeDesforges for some reason I'm unable to add you as reviewer here, even tho you're listed as maintainer.

@GuillaumeDesforges
Copy link
Contributor

Diff looks reasonable, but I have no powers here 🙂

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp stigtsp merged commit 66a9a80 into NixOS:master Jun 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants