Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPAdes: refactor #320317

Merged
merged 1 commit into from
Jun 16, 2024
Merged

SPAdes: refactor #320317

merged 1 commit into from
Jun 16, 2024

Conversation

quantenzitrone
Copy link
Contributor

Description of changes

renamed to fit package naming conventions
split of #319219

I also pointed src and meta.homepage to the new website and github repo, since the old one is dead

there is a new version as well, but I didn't want to touch this as much
@bzizou you might want to do that

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@superherointj superherointj self-assigned this Jun 16, 2024
also point src and meta.homepage to the new website and github repo
Copy link
Contributor

@superherointj superherointj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good.
I'm waiting for CI to merge w/ squash (to fix commit message).

@superherointj superherointj merged commit 63b875e into NixOS:master Jun 16, 2024
26 checks passed
@bzizou
Copy link
Contributor

bzizou commented Jun 17, 2024

Thank you for that! I'll check for the 4.0.0 version...

@quantenzitrone quantenzitrone deleted the spades branch June 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants