river: 0.3.2 -> 0.3.3 #320206
Merged
river: 0.3.2 -> 0.3.3 #320206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
kirillrdy
reviewed
Jun 16, 2024
| @@ -15,14 +15,14 @@ | |||
| , wayland-protocols | |||
| , wlroots_0_17 | |||
| , xwayland | |||
| , zig_0_12 | |||
| , zig_0_13 | |||
There was a problem hiding this comment.
those overrides should be done in all-packages,nix
since this PR didn't introduce this, this is optional
There was a problem hiding this comment.
What about the packages in by-name? They are not imported in all-packages.
Genuinely curious.
There was a problem hiding this comment.
follow the link I've provided
specifically this
So instead it is preferable to use the same generic parameter name libbar and override its value in pkgs/top-level/all-packages.nix:
{
libfoo = callPackage ../by-name/so/some-package/package.nix {
libbar = libbar_2;
};
}
normally by-name packages are not listed in all-packages.nix, but for such overrides they can be added to all-packages.nix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.