pest-ide-tools: remove openssl dependency & MIT license #320064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl was dropped in favor of rustls in 0.3.9 pest-parser/pest-ide-tools@7d6d1ef Despite the common practise among rustaceans to use a dual Apache-2.0/MIT license, `pest-ide-tools` has only ever been licensed under Apache-2.0 https://github.com/pest-parser/pest-ide-tools/commits/v0.3.11/LICENSE
h7x4
approved these changes
Jun 15, 2024
|
I guess it is not going to ping the maintainer automatically, so @NickHu. |
h7x4
reviewed
Jun 15, 2024
Comment on lines
30
to
+31
| homepage = "https://pest.rs"; | ||
| license = with licenses; [ mit asl20 ]; | ||
| license = with licenses; [ asl20 ]; |
There was a problem hiding this comment.
It's probably not a big deal, but I think I would consider the license change and the dependency change to be two different changes, warranting two different commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openssl was dropped in favor of rustls in 0.3.91
Despite the common practise among rustaceans to use a dual Apache-2.0/MIT license,
pest-ide-toolshas only ever been licensed under Apache-2.02Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"4. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
Footnotes
https://github.com/pest-parser/pest-ide-tools/commit/7d6d1ef59a386e30d5e7bb7ced4d7bd1c75101b7 ↩
https://github.com/pest-parser/pest-ide-tools/commits/v0.3.11/LICENSE ↩
This package has 0 tests, so I have technically run all the tests for it. ↩
Wow, this was consuming like 9.5 gigs of RAM & 100% CPU (1 core out of 12) for solid 10 minutes. What an experience. ↩