Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python10Packages.hatch-vcs: fix broken hatch-vcs on pythons 39 and 310 #320039

Merged
merged 3 commits into from
Jun 15, 2024

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jun 15, 2024

Description of changes

hatch-vcs tests are failing due to pypa/setuptools_scm#1038
which is fixed in setuptools_scm 8.1.0.

This is a workaround until that can be upgraded.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt
Copy link
Member

We rely on nixfmt-rfc-style for formatting.

@cpcloud cpcloud force-pushed the fix-broken-hatch-vcs-py39-py310 branch from e552865 to b1264a0 Compare June 15, 2024 12:11
@cpcloud cpcloud requested a review from mweinelt June 15, 2024 12:11
@mweinelt
Copy link
Member

Waiting for CI to finish

@cpcloud
Copy link
Contributor Author

cpcloud commented Jun 15, 2024

@mweinelt Looks like CI is finished!

@mweinelt mweinelt changed the title python39.pkgs.hatch-vcs: fix broken hatch-vcs on pythons 39 and 310 python10Packages.hatch-vcs: fix broken hatch-vcs on pythons 39 and 310 Jun 15, 2024
@mweinelt mweinelt merged commit 176225f into NixOS:master Jun 15, 2024
22 checks passed
@cpcloud cpcloud deleted the fix-broken-hatch-vcs-py39-py310 branch June 15, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants