Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff: 0.4.8 -> 0.4.9 #319920

Merged
merged 1 commit into from
Jun 19, 2024
Merged

ruff: 0.4.8 -> 0.4.9 #319920

merged 1 commit into from
Jun 19, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jun 14, 2024 •
edited
Loading

Description of changes

Changelog: https://github.com/astral-sh/ruff/releases/tag/v0.4.9

cc @figsoda

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@GaetanLepage GaetanLepage marked this pull request as draft June 14, 2024 22:26
@ofborg ofborg bot requested a review from figsoda June 14, 2024 23:12
@GaetanLepage
Copy link
Contributor Author

Some tests are failing:

failures:

---- semantic::tests::expression_scope stdout ----
thread 'semantic::tests::expression_scope' panicked at crates/red_knot/src/semantic/symbol_table.rs:243:31:
index out of bounds: the len is 0 but the index is 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- semantic::tests::reachability_trivial stdout ----
thread 'semantic::tests::reachability_trivial' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 2

---- semantic::types::infer::tests::if_elif stdout ----
thread 'semantic::types::infer::tests::if_elif' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 11

---- semantic::types::infer::tests::follow_import_to_class stdout ----
thread 'semantic::types::infer::tests::follow_import_to_class' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 0

---- semantic::types::infer::tests::if_elif_else stdout ----
thread 'semantic::types::infer::tests::if_elif_else' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 17

---- semantic::types::infer::tests::ifexpr_walrus_2 stdout ----
thread 'semantic::types::infer::tests::ifexpr_walrus_2' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 10

---- semantic::types::infer::tests::ifexpr_walrus stdout ----
thread 'semantic::types::infer::tests::ifexpr_walrus' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 12

---- semantic::types::infer::tests::join_paths stdout ----
thread 'semantic::types::infer::tests::join_paths' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 7

---- semantic::types::infer::tests::maybe_unbound stdout ----
thread 'semantic::types::infer::tests::maybe_unbound' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 3

---- semantic::types::infer::tests::narrow_none stdout ----
thread 'semantic::types::infer::tests::narrow_none' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 12

---- semantic::types::infer::tests::literal_int_arithmetic stdout ----
thread 'semantic::types::infer::tests::literal_int_arithmetic' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 5

---- semantic::types::infer::tests::resolve_base_class_by_name stdout ----
thread 'semantic::types::infer::tests::resolve_base_class_by_name' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 0

---- semantic::types::infer::tests::resolve_module_member stdout ----
thread 'semantic::types::infer::tests::resolve_module_member' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 1

---- semantic::types::infer::tests::resolve_visible_def stdout ----
thread 'semantic::types::infer::tests::resolve_visible_def' panicked at crates/red_knot/src/semantic/flow_graph.rs:59:28:
index out of bounds: the len is 0 but the index is 4


failures:
    semantic::tests::expression_scope
    semantic::tests::reachability_trivial
    semantic::types::infer::tests::follow_import_to_class
    semantic::types::infer::tests::if_elif
    semantic::types::infer::tests::if_elif_else
    semantic::types::infer::tests::ifexpr_walrus
    semantic::types::infer::tests::ifexpr_walrus_2
    semantic::types::infer::tests::join_paths
    semantic::types::infer::tests::literal_int_arithmetic
    semantic::types::infer::tests::maybe_unbound
    semantic::types::infer::tests::narrow_none
    semantic::types::infer::tests::resolve_base_class_by_name
    semantic::types::infer::tests::resolve_module_member
    semantic::types::infer::tests::resolve_visible_def

test result: FAILED. 61 passed; 14 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

error: test failed, to rerun pass `-p red_knot --lib`

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 319920 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • khoj
  • khoj.dist
8 packages failed to build:
  • maigret
  • maigret.dist
  • python311Packages.pyhanko
  • python311Packages.pyhanko.dist
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • sasview
  • sasview.dist
54 packages built:
  • dmarc-metrics-exporter
  • dmarc-metrics-exporter.dist
  • emacsPackages.lsp-bridge
  • nbqa
  • nbqa.dist
  • open-webui
  • open-webui.dist
  • pentestgpt
  • pentestgpt.dist
  • python311Packages.instructor
  • python311Packages.instructor.dist
  • python311Packages.langchain
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python311Packages.langchain-community
  • python311Packages.langchain-community.dist
  • python311Packages.langchain-core
  • python311Packages.langchain-core.dist
  • python311Packages.langchain-text-splitters
  • python311Packages.langchain-text-splitters.dist
  • python311Packages.langchain.dist
  • python311Packages.langsmith
  • python311Packages.langsmith.dist
  • python311Packages.pytest-examples
  • python311Packages.pytest-examples.dist
  • python311Packages.python-lsp-ruff
  • python311Packages.python-lsp-ruff.dist
  • python311Packages.xsdata
  • python311Packages.xsdata.dist
  • python312Packages.instructor
  • python312Packages.instructor.dist
  • python312Packages.langchain
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
  • python312Packages.langchain-core
  • python312Packages.langchain-core.dist
  • python312Packages.langchain-text-splitters
  • python312Packages.langchain-text-splitters.dist
  • python312Packages.langchain.dist
  • python312Packages.langsmith
  • python312Packages.langsmith.dist
  • python312Packages.pytest-examples
  • python312Packages.pytest-examples.dist
  • python312Packages.python-lsp-ruff
  • python312Packages.python-lsp-ruff.dist
  • python312Packages.xsdata
  • python312Packages.xsdata.dist
  • ruff
  • ruff-lsp
  • ruff-lsp.dist
  • shell-gpt
  • shell-gpt.dist
  • vunnel
  • vunnel.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 319920 run on aarch64-linux 1

8 packages marked as broken and skipped:
  • khoj
  • khoj.dist
  • open-webui
  • open-webui.dist
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
8 packages failed to build:
  • maigret
  • maigret.dist
  • python311Packages.pyhanko
  • python311Packages.pyhanko.dist
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • sasview
  • sasview.dist
48 packages built:
  • dmarc-metrics-exporter
  • dmarc-metrics-exporter.dist
  • emacsPackages.lsp-bridge
  • nbqa
  • nbqa.dist
  • pentestgpt
  • pentestgpt.dist
  • python311Packages.instructor
  • python311Packages.instructor.dist
  • python311Packages.langchain
  • python311Packages.langchain-community
  • python311Packages.langchain-community.dist
  • python311Packages.langchain-core
  • python311Packages.langchain-core.dist
  • python311Packages.langchain-text-splitters
  • python311Packages.langchain-text-splitters.dist
  • python311Packages.langchain.dist
  • python311Packages.langsmith
  • python311Packages.langsmith.dist
  • python311Packages.pytest-examples
  • python311Packages.pytest-examples.dist
  • python311Packages.python-lsp-ruff
  • python311Packages.python-lsp-ruff.dist
  • python311Packages.xsdata
  • python311Packages.xsdata.dist
  • python312Packages.instructor
  • python312Packages.instructor.dist
  • python312Packages.langchain
  • python312Packages.langchain-core
  • python312Packages.langchain-core.dist
  • python312Packages.langchain-text-splitters
  • python312Packages.langchain-text-splitters.dist
  • python312Packages.langchain.dist
  • python312Packages.langsmith
  • python312Packages.langsmith.dist
  • python312Packages.pytest-examples
  • python312Packages.pytest-examples.dist
  • python312Packages.python-lsp-ruff
  • python312Packages.python-lsp-ruff.dist
  • python312Packages.xsdata
  • python312Packages.xsdata.dist
  • ruff
  • ruff-lsp
  • ruff-lsp.dist
  • shell-gpt
  • shell-gpt.dist
  • vunnel
  • vunnel.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 319920 run on aarch64-darwin 1

2 packages marked as broken and skipped:
  • khoj
  • khoj.dist
18 packages failed to build:
  • dmarc-metrics-exporter
  • dmarc-metrics-exporter.dist
  • maigret
  • maigret.dist
  • open-webui
  • open-webui.dist
  • pentestgpt
  • pentestgpt.dist
  • python311Packages.pyhanko
  • python311Packages.pyhanko.dist
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • sasview
  • sasview.dist
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references
48 packages built:
  • emacsPackages.lsp-bridge
  • nbqa
  • nbqa.dist
  • python311Packages.instructor
  • python311Packages.instructor.dist
  • python311Packages.langchain
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python311Packages.langchain-community
  • python311Packages.langchain-community.dist
  • python311Packages.langchain-core
  • python311Packages.langchain-core.dist
  • python311Packages.langchain-text-splitters
  • python311Packages.langchain-text-splitters.dist
  • python311Packages.langchain.dist
  • python311Packages.langsmith
  • python311Packages.langsmith.dist
  • python311Packages.pytest-examples
  • python311Packages.pytest-examples.dist
  • python311Packages.python-lsp-ruff
  • python311Packages.python-lsp-ruff.dist
  • python311Packages.xsdata
  • python311Packages.xsdata.dist
  • python312Packages.instructor
  • python312Packages.instructor.dist
  • python312Packages.langchain
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
  • python312Packages.langchain-core
  • python312Packages.langchain-core.dist
  • python312Packages.langchain-text-splitters
  • python312Packages.langchain-text-splitters.dist
  • python312Packages.langchain.dist
  • python312Packages.langsmith
  • python312Packages.langsmith.dist
  • python312Packages.pytest-examples
  • python312Packages.pytest-examples.dist
  • python312Packages.python-lsp-ruff
  • python312Packages.python-lsp-ruff.dist
  • python312Packages.xsdata
  • python312Packages.xsdata.dist
  • ruff
  • ruff-lsp
  • ruff-lsp.dist
  • shell-gpt
  • shell-gpt.dist
  • vunnel
  • vunnel.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 319920 run on x86_64-darwin 1

4 packages marked as broken and skipped:
  • khoj
  • khoj.dist
  • open-webui
  • open-webui.dist
16 packages failed to build:
  • dmarc-metrics-exporter
  • dmarc-metrics-exporter.dist
  • maigret
  • maigret.dist
  • pentestgpt
  • pentestgpt.dist
  • python311Packages.pyhanko
  • python311Packages.pyhanko.dist
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • sasview
  • sasview.dist
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references
48 packages built:
  • emacsPackages.lsp-bridge
  • nbqa
  • nbqa.dist
  • python311Packages.instructor
  • python311Packages.instructor.dist
  • python311Packages.langchain
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python311Packages.langchain-community
  • python311Packages.langchain-community.dist
  • python311Packages.langchain-core
  • python311Packages.langchain-core.dist
  • python311Packages.langchain-text-splitters
  • python311Packages.langchain-text-splitters.dist
  • python311Packages.langchain.dist
  • python311Packages.langsmith
  • python311Packages.langsmith.dist
  • python311Packages.pytest-examples
  • python311Packages.pytest-examples.dist
  • python311Packages.python-lsp-ruff
  • python311Packages.python-lsp-ruff.dist
  • python311Packages.xsdata
  • python311Packages.xsdata.dist
  • python312Packages.instructor
  • python312Packages.instructor.dist
  • python312Packages.langchain
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
  • python312Packages.langchain-core
  • python312Packages.langchain-core.dist
  • python312Packages.langchain-text-splitters
  • python312Packages.langchain-text-splitters.dist
  • python312Packages.langchain.dist
  • python312Packages.langsmith
  • python312Packages.langsmith.dist
  • python312Packages.pytest-examples
  • python312Packages.pytest-examples.dist
  • python312Packages.python-lsp-ruff
  • python312Packages.python-lsp-ruff.dist
  • python312Packages.xsdata
  • python312Packages.xsdata.dist
  • ruff
  • ruff-lsp
  • ruff-lsp.dist
  • shell-gpt
  • shell-gpt.dist
  • vunnel
  • vunnel.dist

@GaetanLepage GaetanLepage marked this pull request as ready for review June 18, 2024 21:45
@GaetanLepage GaetanLepage requested a review from drupol June 18, 2024 21:45
@drupol drupol merged commit 31a1316 into NixOS:master Jun 19, 2024
36 checks passed
@GaetanLepage GaetanLepage deleted the ruff branch June 19, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda Awaiting requested review from figsoda

@drupol drupol Awaiting requested review from drupol

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GaetanLepage @drupol