nixos/{nano,vim,emacs}: move editor specific pathsToLink to their specific module
#319910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathsToLink to their specific module
pathsToLink to their specific modulepathsToLink to their specific module
jian-lin
requested changes
Jun 15, 2024
Comment on lines
21
to
+24
| config = lib.mkIf cfg.defaultEditor { | ||
| environment.systemPackages = [ cfg.package ]; | ||
| environment.variables = { EDITOR = lib.mkOverride 900 "vim"; }; | ||
| environment.pathsToLink = [ "/share/vim-plugins" ]; |
There was a problem hiding this comment.
This breaks users who use vim (environment.systemPackages = [ vim ]) as a non-default editor (programs.vim.defaultEditor = false). A release note is needed at least.
There was a problem hiding this comment.
The vim module should probably get a refactor, to have a separated enable option.
| @@ -85,6 +85,8 @@ in | |||
| environment.systemPackages = [ cfg.package editorScript ]; | |||
|
|
|||
| environment.variables.EDITOR = mkIf cfg.defaultEditor (mkOverride 900 "emacseditor"); | |||
|
|
|||
| environment.pathsToLink = [ "/share/emacs" ]; | |||
There was a problem hiding this comment.
For Emacs, this is wrong. This module is not programs.emacs, it is services.emacs which is used to config an Emacs daemon. Not all Emacs users want to use the services.emacs module.
There was a problem hiding this comment.
Did not realize that, that was only a service for emacs and not emacs itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
No need to link editor specific path into
/run/current-system/sw/if the editor is not enabled.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.