Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfind: 0.4.0 -> 0.4.3 #319861

Merged
merged 1 commit into from
Jun 16, 2024
Merged

zfind: 0.4.0 -> 0.4.3 #319861

merged 1 commit into from
Jun 16, 2024

Conversation

eeedean
Copy link
Contributor

@eeedean eeedean commented Jun 14, 2024

Description of changes

Version changes

v0.4.1
improve error reporting

v0.4.2
fix zip/7z dir name+type
add ext, ext2

v0.4.3
fix symlinks
fix archive sort

nixpkgs formatting

fixed formatting using nix run nixpkgs#nixfmt-rfc-style -- nixfmt pkgs/by-name/zf/zfind/package.nix

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@applePrincess
Copy link
Contributor

Result of nixpkgs-review pr 319861 run on x86_64-linux 1

1 package built:
  • zfind

@h7x4 h7x4 merged commit 019d779 into NixOS:master Jun 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants