Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

clever-tools: init at 3.7.0 #319818

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Conversation

florian-sanders-cc
Copy link
Contributor

Description of changes

Adds the clever-tools package.
This CLI allows users to deploy on Clever Cloud and control their applications, add-ons, services from command line.

Several of Clever Cloud employees actually use NixOS daily and we have a growing number of customers using Nix as well so upstreaming this package would be great.

More employees will be added as maintainers later on so I created a team.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Contributor

@dani0854 dani0854 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package builds on x86_64-linux
  • executables tested on x86_64-linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • meta.mainProgram is set, if applicable.
  • source is fetched using the appropriate function
  • the list of phases is not overridden
  • github username matches githubId

pkgs/by-name/cl/clever-tools/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cl/clever-tools/package.nix Show resolved Hide resolved
pkgs/by-name/cl/clever-tools/package.nix Show resolved Hide resolved
pkgs/by-name/cl/clever-tools/package.nix Show resolved Hide resolved
@florian-sanders-cc
Copy link
Contributor Author

Thanks a lot for your time and your feedback.

Everything should be fixed but don't hesitate to tell me if we can improve stuff.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1754

pkgs/by-name/cl/clever-tools/package.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@jtbx jtbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, looks good 馃憤

@florian-sanders-cc florian-sanders-cc force-pushed the clever-tools branch 3 times, most recently from 40cf53b to 23f92ed Compare June 19, 2024 09:02
@florian-sanders-cc
Copy link
Contributor Author

Everything should be fixed, I'm not quite sure what to do about team-list.nix formatting.
I've formatted the file to make it pass CI Checks, don't hesitate to tell me if it needs to be reverted 馃憤

maintainers/team-list.nix Outdated Show resolved Hide resolved
@florian-sanders-cc
Copy link
Contributor Author

Do I need to do anything to ask for more reviews or ask for it to be merged?
I'm not sure about the process since it's my first PR 馃憖

@florian-sanders-cc
Copy link
Contributor Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@florian-sanders-cc merge not permitted (#305350):
maintainers/maintainer-list.nix is not in pkgs/by-name/
maintainers/team-list.nix is not in pkgs/by-name/

@florian-sanders-cc
Copy link
Contributor Author

Figured it wouldn't work before this PR was merged but was worth the try cause I didn't want to bother anyone. Sorry for the spam 馃槈

@dani0854
Copy link
Contributor

Looks like this PR is waiting for @Aleksanaa review, or I don't quite understand why approvals: 2 label got removed.

pkgs/by-name/cl/clever-tools/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cl/clever-tools/package.nix Outdated Show resolved Hide resolved
@rhendric rhendric merged commit 2a0146f into NixOS:master Jun 29, 2024
25 checks passed
@florian-sanders-cc florian-sanders-cc deleted the clever-tools branch June 30, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants