-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
clever-tools: init at 3.7.0 #319818
clever-tools: init at 3.7.0 #319818
Conversation
37d43ce
to
5ef6e9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed points
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package builds on x86_64-linux
- executables tested on x86_64-linux
-
meta.description
is set and fits guidelines -
meta.license
fits upstream license -
meta.platforms
is set -
meta.maintainers
is set -
meta.mainProgram
is set, if applicable. - source is fetched using the appropriate function
- the list of
phases
is not overridden - github username matches
githubId
5ef6e9e
to
24b5f01
Compare
Thanks a lot for your time and your feedback. Everything should be fixed but don't hesitate to tell me if we can improve stuff. |
24b5f01
to
2cde7b1
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1754 |
2cde7b1
to
b27f448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that, looks good 馃憤
40cf53b
to
23f92ed
Compare
Everything should be fixed, I'm not quite sure what to do about |
23f92ed
to
66be354
Compare
Do I need to do anything to ask for more reviews or ask for it to be merged? |
@NixOS/nixpkgs-merge-bot merge |
@florian-sanders-cc merge not permitted (#305350): |
Figured it wouldn't work before this PR was merged but was worth the try cause I didn't want to bother anyone. Sorry for the spam 馃槈 |
Looks like this PR is waiting for @Aleksanaa review, or I don't quite understand why |
66be354
to
f7d0c48
Compare
Description of changes
Adds the clever-tools package.
This CLI allows users to deploy on Clever Cloud and control their applications, add-ons, services from command line.
Several of Clever Cloud employees actually use NixOS daily and we have a growing number of customers using Nix as well so upstreaming this package would be great.
More employees will be added as maintainers later on so I created a team.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.