Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harminv: fix wrong hash (copy of libgdsii) #319801

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

sheepforce
Copy link
Member

Description of changes

Fixes wrong hash of the harminv package, which was a copy of the libGDSII hash by accident.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@markuskowa
Copy link
Member

There seems to be a build problem.

@sheepforce
Copy link
Member Author

There seems to be a build problem.

Hu, that was why --enable-maintainer-mode is required 😄 I will enable it again. Was apparently required in the first place.

enable maintainer mode to create copyright.h

remove wrong main program meta
@markuskowa markuskowa merged commit 2c7869d into NixOS:master Jun 17, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants