moonlight-qt: 5.0.1 -> 6.0.1, and other enhancements

[azuwis]

Description of changes

• 5.0.1 -> 6.0.0 https://github.com/moonlight-stream/moonlight-qt/releases/tag/v6.0.0
• Use upstream patches to handle darwin prebuilts
• New upstream deps libplacebo and vulkan-headers
• Move to pkgs/by-name
• Format using nixfmt-rfc-style and sort args
• Add passthru.updateScript
• 6.0.0 -> 6.0.1 https://github.com/moonlight-stream/moonlight-qt/releases/tag/v6.0.1

Replace #318940

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Tungsten842]

It seems that they ship with qt6 by default almost everywhere, can we use it as well?

[azuwis]

I've tried qt6, but encounter the same problem as https://github.com/NixOS/nixpkgs/pull/252446/checks?check_run_id=18159712763

It seems qmake look for the wrong path for qmlcachegen.

[SuperSandro2000]

That's an upstream issue most likely

[cgutman]

If you mean moonlight-qt upstream, we're not really doing anything special other than asking for precompiled QML files using the documented CONFIG option. https://github.com/moonlight-stream/moonlight-qt/blob/17a25484805ef927ad7c1b2906f885ee26eda928/app/app.pro#L13-L20

However, the QML precompilation is probably undesirable in the case of CONFIG+=disable-prebuilts since that is asking explicitly for Moonlight not to internally bundle all of our dependencies. Using precompiled QML without bundling Qt could lead to the precompiled qmlc files being useless if the compile-time Qt version doesn't exactly match the runtime Qt version. I've checked in a patch to avoid this scenario, which may also allow you to migrate Moonlight to Qt 6 in NixOS.

[azuwis]

@cgutman I was wondering why the problem exists on darwin but not linux, thanks for the explanation.

The fix/workaround is to disable qtquickcompiler qmake flag.

I've made a PR for qt6 with this patch #324703.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4137

[zmitchell]

Thanks for picking up where I left off!

[zmitchell]

@azuwis I think you still need to run tests and fill out the rest of the PR template for this to proceed

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/intel-video-acceleration-changes-going-from-23-11-24-05/48377/12