-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moonlight-qt: 5.0.1 -> 6.0.1, and other enhancements #319743
Conversation
fetchpatch, | ||
darwin, | ||
overrideSDK, | ||
libsForQt5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that they ship with qt6 by default almost everywhere, can we use it as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried qt6, but encounter the same problem as https://github.com/NixOS/nixpkgs/pull/252446/checks?check_run_id=18159712763
It seems qmake look for the wrong path for qmlcachegen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an upstream issue most likely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean moonlight-qt upstream, we're not really doing anything special other than asking for precompiled QML files using the documented CONFIG
option. https://github.com/moonlight-stream/moonlight-qt/blob/17a25484805ef927ad7c1b2906f885ee26eda928/app/app.pro#L13-L20
However, the QML precompilation is probably undesirable in the case of CONFIG+=disable-prebuilts
since that is asking explicitly for Moonlight not to internally bundle all of our dependencies. Using precompiled QML without bundling Qt could lead to the precompiled qmlc files being useless if the compile-time Qt version doesn't exactly match the runtime Qt version. I've checked in a patch to avoid this scenario, which may also allow you to migrate Moonlight to Qt 6 in NixOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4137 |
Thanks for picking up where I left off! |
@azuwis I think you still need to run tests and fill out the rest of the PR template for this to proceed |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/intel-video-acceleration-changes-going-from-23-11-24-05/48377/12 |
Description of changes
Replace #318940
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.