Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpvScripts.thumbnail: 0.5.3 -> 0.5.4 #319722

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

Xelden
Copy link
Contributor

@Xelden Xelden commented Jun 14, 2024

Description of changes

Current version throws this error:

[mpv_thumbnail_script_client_osc] 
[mpv_thumbnail_script_client_osc] stack traceback:
[mpv_thumbnail_script_client_osc] 	....3/share/mpv/scripts/mpv_thumbnail_script_client_osc.lua:4466: in function 'visibility_mode'
[mpv_thumbnail_script_client_osc] 	....3/share/mpv/scripts/mpv_thumbnail_script_client_osc.lua:4509: in main chunk
[mpv_thumbnail_script_client_osc] 	[C]: in ?
[mpv_thumbnail_script_client_osc] 	[C]: in ?
[mpv_thumbnail_script_client_osc] Lua error: ....3/share/mpv/scripts/mpv_thumbnail_script_client_osc.lua:4466: attempt to call field 'shared_script_property_set' (a nil value)

Changelog: marzzzello/mpv_thumbnail_script@0.5.3...0.5.4

EDIT by JohnRTitor: Closes #312827

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 319722 run on x86_64-linux 1

1 package built:
  • mpvScripts.thumbnail

@JohnRTitor JohnRTitor merged commit 19be9b9 into NixOS:master Jun 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants