Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow: 4.14.6 -> 4.16.0 #319655

Merged
merged 1 commit into from
Jul 9, 2024
Merged

shadow: 4.14.6 -> 4.16.0 #319655

merged 1 commit into from
Jul 9, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jun 13, 2024

Changes:

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi trofi changed the title shadow: 4.414.6 -> 4.15.1 shadow: 4.14.6 -> 4.16.0 Jul 6, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4211

@philiptaron
Copy link
Contributor

I'm building my system using this PR. Small builds worked.

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full system build succeeded.

@SuperSandro2000
Copy link
Member

Is the build randomly failing?

echo | /build/build/./gcc/xgcc -B/build/build/./gcc/  -E -dM - | \
  sed -n -e 's/^#define \([^_][a-zA-Z0-9_]*\).*/\1/p' \
         -e 's/^#define \(_[^_A-Z][a-zA-Z0-9_]*\).*/\1/p' | \
  sort -u > tmp-macro_list
      tokens bs:                                   OK
      tokens lbs:                                  OK
    n_number_real_garbage_after_e.json
      decode:                                      OK
      tokens bs:                                   OK
      tokens lbs:                                  OK
    n_number_real_with_invalid_utf8_after_e.json
      decode:                                      OK
      tokens bs:                                   OK
cc1: error: no include path in which to search for stdc-predef.h
      tokens lbs:                                  OK
    n_number_real_without_fractional_part.json
      decode:                                      OK
/nix/store/r5d7s4y3r3q2s8xr4naih9s2is04lcxa-bash-5.2p26/bin/bash ../../gcc-13.3.0/gcc/../move-if-change tmp-macro_list macro_list
      tokens bs:                                   OK
      tokens lbs:                                  OK
    n_number_starting_with_dot.json
      decode:                                      OK
      tokens bs:                                   OK
      tokens lbs:                                  OK
    n_number_with_alpha.json
      decode:                                      OK
echo timestamp > s-macro_list
      tokens bs:                                   OK
      tokens lbs:                                  OK

@trofi
Copy link
Contributor Author

trofi commented Jul 9, 2024

Is the build randomly failing?

echo | /build/build/./gcc/xgcc -B/build/build/./gcc/  -E -dM - | \
  sed -n -e 's/^#define \([^_][a-zA-Z0-9_]*\).*/\1/p' \
         -e 's/^#define \(_[^_A-Z][a-zA-Z0-9_]*\).*/\1/p' | \
  sort -u > tmp-macro_list
      tokens bs:                                   OK
      tokens lbs:                                  OK
    n_number_real_garbage_after_e.json
      decode:                                      OK
      tokens bs:                                   OK
      tokens lbs:                                  OK
    n_number_real_with_invalid_utf8_after_e.json
      decode:                                      OK
      tokens bs:                                   OK
cc1: error: no include path in which to search for stdc-predef.h
      tokens lbs:                                  OK
    n_number_real_without_fractional_part.json
      decode:                                      OK
/nix/store/r5d7s4y3r3q2s8xr4naih9s2is04lcxa-bash-5.2p26/bin/bash ../../gcc-13.3.0/gcc/../move-if-change tmp-macro_list macro_list
      tokens bs:                                   OK
      tokens lbs:                                  OK
    n_number_starting_with_dot.json
      decode:                                      OK
      tokens bs:                                   OK
      tokens lbs:                                  OK
    n_number_with_alpha.json
      decode:                                      OK
echo timestamp > s-macro_list
      tokens bs:                                   OK
      tokens lbs:                                  OK

I suspect you are looking at mix of aeson-tests and gcc build logs (no shadow build here).

On ofborg I had to click to show all logs to get real .drv failure. I think it's this one:

error: building of '/nix/store/38176amg8zgvrxgn8hlm3lyjx8anhr3y-python3.12-virtualenv-20.26.2.drv^out' from .drv file timed out after 3600 seconds

@SuperSandro2000 SuperSandro2000 merged commit edbd95a into NixOS:staging Jul 9, 2024
30 checks passed
@trofi trofi deleted the shadow-update branch July 10, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants