Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mattermost: remove redundant buildGoModule argument from callPackage site #319633

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

stuebinm
Copy link
Contributor

Description of changes

the default version was raised to Go 1.22 in #290212, so it is no longer necessary to set it explicitly.

This PR is a no-op as far as the evaluated package is concerned; its hash stays identical.

(@numinit since ofborg won't pick this up I'm pinging you manually)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

the default version was raised to Go 1.22 in
94ed078, so it is no longer
necessary to set it explicitly.
@stuebinm stuebinm changed the title mattermost: remove obsolete argument from callPackage mattermost: remove redundant buildGoModule argument from callPackage site Jun 13, 2024
@drupol drupol merged commit a6c35d1 into NixOS:master Jun 16, 2024
28 checks passed
@numinit numinit added the backport release-24.05 Backport PR automatically label Jun 17, 2024
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants