Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 1.90.0 -> 1.90.1 #319626

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for vscode is: Open source source code editor developed by Microsoft for Windows,
Linux and macOS

meta.homepage for vscode is: https://code.visualstudio.com/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 1.90.1 with grep in /nix/store/qj6dh4x4x9lf3sii0r9nmgiq0q60x3va-vscode-1.90.1
  • found 1.90.1 in filename of file in /nix/store/qj6dh4x4x9lf3sii0r9nmgiq0q60x3va-vscode-1.90.1

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

vscode
vscode-fhs
vscode-with-extensions
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/qj6dh4x4x9lf3sii0r9nmgiq0q60x3va-vscode-1.90.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A vscode https://github.com/r-ryantm/nixpkgs/archive/e51b44d1009fd1eefaf6eb3ba0d776183f3c9b57.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/e51b44d1009fd1eefaf6eb3ba0d776183f3c9b57#vscode

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/qj6dh4x4x9lf3sii0r9nmgiq0q60x3va-vscode-1.90.1
ls -la /nix/store/qj6dh4x4x9lf3sii0r9nmgiq0q60x3va-vscode-1.90.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

3 packages built:
  • vscode
  • vscode-fhs
  • vscode-with-extensions

Maintainer pings

cc @eadwu @Synthetica9 @bobby285271 @Enzime for testing.

@ninelore
Copy link
Contributor

ninelore commented Jun 14, 2024

Result of nixpkgs-review pr 319626 run on x86_64-linux 1

3 packages failed to build:
  • vscode
  • vscode-fhs
  • vscode-with-extensions

Failed due to a connection reset by GH, please disregard

@ninelore
Copy link
Contributor

Result of nixpkgs-review pr 319626 run on x86_64-linux 1

3 packages built:
  • vscode
  • vscode-fhs
  • vscode-with-extensions

Copy link
Contributor

@ninelore ninelore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested binaries, LGTM

@bobby285271 bobby285271 merged commit 517d846 into NixOS:master Jun 14, 2024
25 of 26 checks passed
@r-ryantm r-ryantm deleted the auto-update/vscode branch June 15, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants