Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In the current version of this package playback support with gstreamer is broken because dependencies are missing.
I stumbled across this when I tried to embed a video in my presentation and running pympress on wayland. As it turns out VLC does not support embedded videos on wayland and opens the video in a new window (see Cimbali/pympress#320). When turning off vlc in the pympress config file videos cannot be played at all because gstreamer does not work.
This PR adds the missing dependencies.
The minimal additional dependencies I need to be able to play an embedded
.mp4
video with gstreamer are:but I think adding full gstreamer support (video/audio hardware acceleration, additional codecs) can't be a bad idea. Let me know what you think!
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)@tbenst @jtojnar @drupol
Add a 👍 reaction to pull requests you find important.