Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] haskell.compiler.*: calculate tool path using common function #319398

Merged
merged 1 commit into from
Aug 2, 2024
Merged

[Backport release-24.05] haskell.compiler.*: calculate tool path using common function #319398

merged 1 commit into from
Aug 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-24.05, triggered by a label in #319044.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@sternenseemann @github-actions
haskell.compiler.*: calculate tool path using common function
2ca340b 
This refactor should simplify the code a little bit and make future
changes easier. I. e. for cross compiling GHC we'll have to update the
tools in the GHC settings file and calculate the host->target tool paths
for later use. Having a ready function for this will make this a lot
easier.

(cherry picked from commit e4324d6)
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Merged
13 tasks
maralorn
maralorn approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged a few of the other back ports, but for this one I thought maybe we wait and see that the upstream PR didn’t accidentally break anything. Highly unlikely, though …

@maralorn maralorn merged commit 930c6cf into release-24.05 Aug 2, 2024
16 checks passed
@maralorn maralorn deleted the backport-319044-to-release-24.05 branch August 2, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann Awaiting requested review from sternenseemann sternenseemann is a code owner

@ncfavier ncfavier Awaiting requested review from ncfavier ncfavier is a code owner

@maralorn maralorn Awaiting requested review from maralorn maralorn is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maralorn @wegank @sternenseemann