Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oama: init at 0.14 #319267

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

oama: init at 0.14 #319267

wants to merge 4 commits into from

Conversation

Melkor333
Copy link
Contributor

Description of changes

Oama is a tool to do OAuth2 on the command line for various command line tools like Mail, Calendar, etc.
It integrates with Gnome keyring or can use GPG to encrypt the secret and can renew the token.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@onny
Copy link
Contributor

onny commented Jun 12, 2024

Can you try to move the new package into the directory pkgs/by-name/oa/oama? Would be good to have all new packages in there

@Melkor333
Copy link
Contributor Author

Can you try to move the new package into the directory pkgs/by-name/oa/oama? Would be good to have all new packages in there

Done. I just don't know how to fix the CI check which says that I call it wrongly (If I need to do that).

@onny
Copy link
Contributor

onny commented Jun 18, 2024

I guess you'll have to remove the entry in all-packages.nix altogether. Only put the package in pkgs/by-name and rename the dependency directly to http2_3_0_3

@Melkor333 Melkor333 changed the title oama: init at 0.13.3 oama: init at 0.14 Jun 27, 2024
@Melkor333
Copy link
Contributor Author

I had to add a redirect. Just using http2_3_0_3 and warp_3_3_30 caused warp build to fail with:

Configuring warp-3.3.30...
CallStack (from HasCallStack):
  withMetadata, called at libraries/Cabal/Cabal/src/Distribution/Simple/Utils.hs:368:14 in Cabal-3.10.3.0:Distribution.Simple.Utils
Error: Setup: Encountered missing or private dependencies:
http2 >=3.0 && <5

Found the solution on discord.

Also bumped the version as I just saw a new release from yesterday :)

@croissong croissong mentioned this pull request Aug 22, 2024
13 tasks
@maralorn
Copy link
Member

maralorn commented Aug 22, 2024

@Melkor333 Sorry, we didn’t notice this PR. (To get attention by the "right" maintainers it helps to add the haskell label or tag the haskell team.) At this point I think #335989 is a bit nicer structured. But maybe you and @aidalgol can coordinate on how to proceed. (My suggestion would be to build on #335989 but enter both of you as maintainers.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants