Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arkenfox-userjs: init at 126.1 #319258

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

Guanran928
Copy link
Contributor

@Guanran928 Guanran928 commented Jun 12, 2024

Description of changes

https://github.com/arkenfox/user.js

Revived #190127
cc: @linsui do you still want to maintain this?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@linsui
Copy link
Contributor

linsui commented Jun 12, 2024

No problem. :)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4090

@SuperSandro2000
Copy link
Member

I think we should create some more value here. What are the steps to integrate this into programs.firefox? Which options do you need to set? If we can easily answer that question or maybe create a little option for that if it isn't easy, we can create some value here.

@linsui
Copy link
Contributor

linsui commented Jun 20, 2024

programs.firefox.autoConfig = builtins.readFile "${pkgs.arkenfox-userjs}/user.cfg";

or

package = pkgs.firefox.overrides {
  extraPrefsFiles = [ "${pkgs.arkenfox-userjs}/user.cfg" ];
};

Maybe we can expose extraPrefsFiles as programs.firefox.autoConfigFiles for convience.

@SuperSandro2000 SuperSandro2000 merged commit 47f47fe into NixOS:master Jun 20, 2024
31 checks passed
@linsui
Copy link
Contributor

linsui commented Jun 20, 2024

#321254 I added the option.

@Guanran928
Copy link
Contributor Author

Guanran928 commented Jun 23, 2024

package = pkgs.firefox.overrides {
  extraPrefsFiles = [ "${pkgs.arkenfox-userjs}/user.cfg" ];
};

Hmm, this didn't really work for me (I was using readFile before, aka IFD), Firefox showed this when I started it.

image

Here's my home-manager configuration: https://github.com/Guanran928/flake/blob/83bc00a358ef10a42e35ea838e75e9350a969514/home/applications/firefox/default.nix
and $out/lib/firefox/mozilla.cfg: https://pb.ny4.dev/T9ISdc.js

Can you reproduce this? Should I open another issue?

UPDATE: @linsui told me in matrix that I should use the .cfg file. I originally thought the defaultPref format was for LibreWolf.

(https://librewolf.net/docs/settings/#common-cfg-recipes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants