kodi-upnext: init at 1.1.9+matrix1

[sanzoghenzo]

This adds the Up Next kodi addon to kodi packages.

Pinging @aanderse who has been very kind supporting me while testing this (see this forum discussion)

Description of changes

Up Next Kodi addon, taken directly form the Kodi repository.

more info

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

I've tested it in a virtual machine and on my HTPC (see link to the discussion above)

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-add-custom-kodi-plugins-yet-another-how-to-use-a-custom-derivation-in-my-flake-post/46238/11

[nvmd]

Hi @sanzoghenzo! Thank you for your PR.

I don't use this addon myself, but I do see that this latest "stable" version is quite old.
Do you it could make sense to package either the latest "unstable" master branch (some issues fixed last and this year)?
Or the fork of the addon by one of its contributors (https://github.com/MoojMidge/service.upnext), which is far more frequently updated and seems to provide overall more value?

[sanzoghenzo]

Hi @nvmd, thank you for taking the time to review this!

I went with the stable version because it's the one that most of the people install, since it is available right on the official kodi repository.

While the fork is intriguing, it adds features that may not be needed by most ( = by me 😅 ) and the first line of the README ("commits are often untested and cause addon to break") is scaring me 🤣

I'd prefer to stick to the "official" version; I see that unstable/master branch version fixes 2 issues, I'll update it.

[aanderse]

i think there is value in using the upstream curated addon as the PR currently stands
i don't want to become an opinionated kodi source more than we need to be

[sanzoghenzo]

i think there is value in using the upstream curated addon as the PR currently stands i don't want to become an opinionated kodi source more than we need to be

It's nice to hear, especially because I have other 6 plugins made in the same way ready for PRs 😅

[nvmd]

i think there is value in using the upstream curated addon as the PR currently stands i don't want to become an opinionated kodi source more than we need to be

Absolutely agree. I just think we had to consider other options (as long as it goes together with the intention of the PR author to add not a package, but some particular functionality it provides for him, and is, ideally, maintained by someone) because I guess we don't want to become a source of upstream, but nevertheless broken/unmaintained/outdated packages either 😀.
Which we did indeed consider, thanks @sanzoghenzo @aanderse

[sanzoghenzo]

Changes made!

[aanderse]

thanks everyone!