-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pahole: 1.26 -> 1.27 #319160
pahole: 1.26 -> 1.27 #319160
Conversation
ofborg tests passed, yay. BTW @delroth -- they added |
That wasn't so bad so updated patch. The output is identical to -j1 output from what I could see. |
Note this apparently introduces a regression in linux builds with clang with LTO enabled:
I don't think we actively do that, but on the other hand there's no strict hurry to merge this either, so let's put this on hold until that is fixed |
New version brought in the --reproducible_build option, which is more efficient than forcing a single thread, and produces the same output (tested on linux kernel's vmlinux BTF extraction)
I was expecting a new release with it but it's been fixed without such ceremony, so I picked the patch up. Also didn't get any response to the reproducibility patch so resent it by e-mail, let's see how that one goes.. This PR was only waiting for the clang fix, so marked as ready again. |
I believe there's no use in pinging Delroth anymore: #307173 |
Doh, thanks for the heads up. FWIW that patch was more or less refused upstream after a few exchanges with upstream, between pahole folks telling me that this belongs in kbuild, and kbuild folks saying this deserves a new .config option... let's just keep that harmless patch around for now. |
Maybe I should upstream a kernel built with Clang and LTO (would help to assert our kernel modules build against this scenario), mine broke after this bump 😢 EDIT: Solution is a second patch by Arnaldo: https://lore.kernel.org/all/ZnGZ71a4E29kPrvS@x1/ |
@PedroHLC doh, sorry... I wish he'd just tagged a fix release instead of posting patches like this :/ especially since on acmel/dwarves#53 someone commented the other patch was enough.. I've just opened #331589 - if you could confirm it works manually that'd be great. |
Description of changes
(Note I don't have enough cpu/disk to build a linux kernel with this, so letting ofborg do the work... Always a bit of a bet on staging. Maybe someday...)
From the release e-mail:
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.