immich-cli: 2.0.6 -> 2.2.4 #319148
Merged
immich-cli: 2.0.6 -> 2.2.4 #319148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Old version is incompatible with the latest Immich server, so this is very welcome! |
pineapplehunter
force-pushed
the
immich-2.2.2
branch
from
d2af322
to
1b3ae64
Compare
pineapplehunter
changed the title
pineapplehunter
force-pushed
the
immich-2.2.2
branch
from
1b3ae64
to
b916741
Compare
pbsds
reviewed
Jun 19, 2024
| tests.version = testers.testVersion { package = immich-cli; }; | ||
| }; | ||
|
|
||
| meta = meta // { mainProgram = "immich"; }; |
There was a problem hiding this comment.
meta // has a tendency to block builtins.unsafeGetAttrPos "description" package.meta used by nixos-search, can you rephase it to meta = { inherit (meta') foo bar baz; mainProgram = "immich"; }?
There was a problem hiding this comment.
Thanks for the review!
Fixed.
pineapplehunter
force-pushed
the
immich-2.2.2
branch
from
b916741
to
a8c07e6
Compare
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates immich-cli to 2.2.4.
An extra step was added to build the SDK, which is required in the newer release.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.