Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kchat: 2.4.0 -> 3.3.1 #319050

Merged
merged 1 commit into from
Jun 21, 2024
Merged

kchat: 2.4.0 -> 3.3.1 #319050

merged 1 commit into from
Jun 21, 2024

Conversation

Vinetos
Copy link
Member

@Vinetos Vinetos commented Jun 11, 2024

Description of changes

Update kchat to the latest version available.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Vinetos
Copy link
Member Author

Vinetos commented Jun 14, 2024

Result of nix run nixpkgs#nixpkgs-review -- pr 319050 run on x86_64-linux 1

1 package built:
  • kchat

Copy link
Contributor

@fin444 fin444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an account so couldn't test any advanced functionality, but everything on the login screen looks fine (x86_64-linux)

@Vinetos
Copy link
Member Author

Vinetos commented Jun 20, 2024

I don't have an account so couldn't test any advanced functionality, but everything on the login screen looks fine (x86_64-linux)

Thanks for the review :D
I do use this update for a week and it is working well !

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 319050 run on x86_64-linux 1

1 package built:
  • kchat

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnRTitor JohnRTitor merged commit 47ea5bd into NixOS:master Jun 21, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants