Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm: 9.1.1 -> 9.3.0 #319042

Merged
merged 1 commit into from
Jun 13, 2024
Merged

pnpm: 9.1.1 -> 9.3.0 #319042

merged 1 commit into from
Jun 13, 2024

Conversation

nathanscully
Copy link
Contributor

Description of changes

Bumping pnpm from 9.1.1 to 9.3.0

master...nathanscully:nixpkgs:pnpm-9.3.0

cc @Scrumplex @doronbehar

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, maybe this is a good opportunity to run a nix build --rebuild on all derivations that have a pnpmDeps attribute?

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 319042 run on x86_64-linux 1

1 package failed to build:
  • surrealist
5 packages built:
  • pgrok
  • pgrok.server
  • pnpm (pnpm_9)
  • renovate
  • youtube-music

@doronbehar
Copy link
Contributor

The surrealist build fails on Hydra as well:

https://hydra.nixos.org/build/263034298

And the log there is missing, because surrealist.embed is failing to build - @MDM23 see build log here:

https://gist.github.com/doronbehar/b165a5912be8bd06b9857a9b35eede8d

I'm not sure why. Besides that, I ran:

nix build --rebuild -Lf. --keep-going \
  pgrok.pnpmDeps \
  renovate.pnpmDeps \
  youtube-music.pnpmDeps \
  surrealist.ui.pnpmDeps

And they all succeeded, hence this version bump looks totally good to me.

@doronbehar doronbehar merged commit 50bcab6 into NixOS:master Jun 13, 2024
26 of 27 checks passed
@Scrumplex
Copy link
Member

I'm not sure why. Besides that, I ran:

nix build --rebuild -Lf. --keep-going \
  pgrok.pnpmDeps \
  renovate.pnpmDeps \
  youtube-music.pnpmDeps \
  surrealist.ui.pnpmDeps

And they all succeeded, hence this version bump looks totally good to me.

I think it would be great if we had an easy way to test all FODs that rely on pnpm when updating. Maybe I can look into writing a test suite.

@MDM23
Copy link
Contributor

MDM23 commented Jun 13, 2024

@doronbehar Strange, I think I had a similar error when initially building the surrealist derivation. Will take a look at it later. I'm also working on updating to the latest version (#307031). Just a bit of rebasing and testing left. With that PR, the issue should be gone as the embed part is not required anymore since version 2.0.

@nathanscully nathanscully deleted the pnpm-9.3.0 branch June 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants