Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftlint: init at 0.55.1 #318906

Merged
merged 1 commit into from
Jun 16, 2024
Merged

swiftlint: init at 0.55.1 #318906

merged 1 commit into from
Jun 16, 2024

Conversation

matteo-pacini
Copy link
Contributor

@matteo-pacini matteo-pacini commented Jun 10, 2024

Description of changes

A tool to enforce Swift style and conventions, commonly used in Xcode development workflows.

Planning to switch to source building once #256956 is finalised and merged (needs Swift 5.9 min).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4073

@DontEatOreo
Copy link
Member

Result of nixpkgs-review pr 318906 run on aarch64-darwin 1

1 package built:
  • swiftlint

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1739

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1745

@matteo-pacini
Copy link
Contributor Author

matteo-pacini commented Jun 14, 2024

Note for whoever merges: need also #319383 merged (includes my entry as maintainer), so I can also backport new packages 🙏🏻

Done, thanks 🙏🏻

@matteo-pacini matteo-pacini added the backport release-24.05 Backport PR automatically label Jun 15, 2024
@matteo-pacini
Copy link
Contributor Author

@wegank ready for merge, thanks 🙏

@wegank wegank merged commit f82fe27 into NixOS:master Jun 16, 2024
26 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants