Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.natural: init at 0.2.0 #318827

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

Sail0rd
Copy link
Contributor

@Sail0rd Sail0rd commented Jun 10, 2024

Description of changes

Python library that Convert data to their natural (human-readable) format
Homepage: https://github.com/tehmaze/natural

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@Sail0rd Sail0rd force-pushed the create-natural branch 2 times, most recently from aa3f177 to 5a85fcf Compare June 11, 2024 08:03
@ofborg ofborg bot requested a review from Vinetos June 11, 2024 08:47
Copy link
Contributor

@Moraxyc Moraxyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! some suggestions

pkgs/development/python-modules/natural/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/natural/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/natural/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit 4fc17f6 into NixOS:master Jun 13, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants