Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kminion: 2.2.7 → 2.2.8, init module #318792

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

kminion: 2.2.7 → 2.2.8, init module #318792

wants to merge 7 commits into from

Conversation

jpds
Copy link
Contributor

@jpds jpds commented Jun 10, 2024

Description of changes

Also adds a module + test case

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jpds jpds force-pushed the kminion-2.2.8+module branch 2 times, most recently from e8e8825 to 5d8cb0c Compare June 10, 2024 13:29
@jpds jpds force-pushed the kminion-2.2.8+module branch 2 times, most recently from 9bfb713 to 8c9dcc0 Compare June 10, 2024 13:49
@ofborg ofborg bot requested a review from cafkafk June 10, 2024 15:26
cafkafk
cafkafk reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for doing this! Not sure why the kminion.passthru.tests on x86_64-darwin fails thou >_>

@jpds jpds force-pushed the kminion-2.2.8+module branch 2 times, most recently from 8f5410e to 299ac66 Compare June 12, 2024 22:38
@ofborg ofborg bot requested a review from cafkafk June 13, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@cafkafk cafkafk Awaiting requested review from cafkafk

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (new) 8.has: module (update) 8.has: package (new) 8.has: tests 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jpds @SuperSandro2000 @cafkafk @wegank @h7x4