nixos/phpfpm: Change phpOptions to structural options

[onny]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Ma27]

This will need a release notes entry.

[jopejoe1]

Here are a few more dots that should be quoted.

[Ma27]

Blocking now due to lack of testing.

(there are far too many instances of foo.bar where it should've been "foo.bar" and given that said option does attrsOf (oneOf [str int]), this shouldn't even evaluate.

[onny]

failing tests

• librenms
• castopod

missing test

• bookstack
• flarum
• zabbix

need to test

• php-fpm
• php pcre
• httpd

[onny]

Somehow the phpOptions attribute set doesn't get appended to the php.ini of the php-fpm pool.

I'm not sure what this function actually do:

  phpIni = poolOpts: pkgs.runCommand "php.ini" {
    inherit (poolOpts) phpPackage;
    phpOptions = toKeyValue cfg.phpOptions;
    preferLocalBuild = true;
    passAsFile = [ "phpOptions" ];
  } ''
    cat ${poolOpts.phpPackage}/etc/php.ini $phpOptionsPath > $out
  '';

I guess php.ini is a command that gets executed and returns a path to a php.ini-file? Where does $phpOptionsPath come from? Which function uses all these parameters phpOptions, preferLocalBuild, phpPackage, etc.?