Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kontemplate: migrate to buildGoModule #318627

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jun 9, 2024

Description of changes

Migrating to buildGoModule so buildGoPackage can be deprecated as per #318069. Project needs an upstream patch to do so, as it does not have a vendor directory, nor is a module.

Also moved to by-name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft msanft requested a review from katexochen June 14, 2024 13:22
@msanft msanft force-pushed the kontemplate/build-go-module branch from 4287b32 to 8eb194f Compare June 14, 2024 13:22
@msanft msanft force-pushed the kontemplate/build-go-module branch from 8eb194f to 1c3c532 Compare June 17, 2024 06:42
@msanft msanft force-pushed the kontemplate/build-go-module branch from 1c3c532 to 21fa9a0 Compare June 17, 2024 06:47
Copy link
Contributor

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 318627 run on x86_64-linux 1

1 package built:
  • kontemplate

@katexochen katexochen merged commit 6315f5a into NixOS:master Jun 17, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants