-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/systemd-networkd: add PREF64 related options #318604
Conversation
Is there a chance we can actually add a test for this? |
Sure thing! A functional test or a test that the config is what we expect? |
I was thinking about a VM test with a "server" configuring such a prefix in their RA announcements, and a client with I didn't check but in case resolved already makes use of this information for AAAA record synthesis (or dnssec validation), doing a query for something with only a A record, and expecting to get back a synthesized record back could be tested too? As far as sending any traffic is concerned, you could get some inspiration from our ipv6 prefix delegation test, but I assume we're still missing some CLAT in Linux? |
@flokli So we do have a clatd test! I added a commit that augments that test to ensure the networkd options work as expected. |
@ofborg test clatd |
We can expose the PLAT prefix to the client via DNS64 so clatd is able to determine the prefix dynamically. We can also test that some systemd-networkd PREF64 settings work as expected when exposed on the router.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to give @hax404 a chance to also review the test additions.
I think it is reasonable to backport this change, as it introduces the declarative interface for functionality present in systemd 255. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-318604-to-release-24.05 origin/release-24.05
cd .worktree/backport-318604-to-release-24.05
git switch --create backport-318604-to-release-24.05
git cherry-pick -x b867cc215f2d01b25f478c6c711b5be9374c3dac d4d5fd718d3ef05b3f47750a6d5462a4e21c321c |
@mweinelt please do the backport manually. |
Description of changes
Tested to work in the legacy nested
*Config
format as well as the newer flattened format.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.