Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arcanist: remove #318104

Merged
merged 1 commit into from
Jun 20, 2024
Merged

arcanist: remove #318104

merged 1 commit into from
Jun 20, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jun 7, 2024

arcanist fails the build time to time due to bugs in Makefile. Recent example: https://hydra.nixos.org/build/262386028

All PRs are being closed in https://github.com/phacility/arcanist/pulls and refer to phabricator not being maintained:

https://secure.phabricator.com/book/phabcontrib/article/contributing_code/

Let's schedule arcanist for removal.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

`arcanist` fails the build time to time due to bugs in Makefile. Recent
example: https://hydra.nixos.org/build/262386028

All PRs are being closed in https://github.com/phacility/arcanist/pulls
and refer to phabricator not being maintained:

https://secure.phabricator.com/book/phabcontrib/article/contributing_code/

Let's schedule `arcanist` for removal.
@Aleksanaa Aleksanaa merged commit 52f0089 into NixOS:master Jun 20, 2024
26 checks passed
@trofi trofi deleted the arcanist-removal branch June 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants