Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nex: migrate to buildGoModule #318094

Merged
merged 1 commit into from
Jun 18, 2024
Merged

nex: migrate to buildGoModule #318094

merged 1 commit into from
Jun 18, 2024

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Jun 7, 2024

Description of changes

Migrating to buildGoModule so buildGoPackage can be deprecated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen
Copy link
Contributor Author

Result of nixpkgs-review pr 318094 run on x86_64-linux 1

2 packages built:
  • mgmt
  • nex

@katexochen katexochen requested a review from msanft June 17, 2024 18:41
@katexochen katexochen merged commit 3ab4462 into NixOS:master Jun 18, 2024
33 checks passed
@katexochen katexochen deleted the nex/mods branch June 18, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants