Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfind: init at 0.4.0 #317742

Merged
merged 1 commit into from
Jun 14, 2024
Merged

zfind: init at 0.4.0 #317742

merged 1 commit into from
Jun 14, 2024

Conversation

eeedean
Copy link
Contributor

@eeedean eeedean commented Jun 6, 2024

Description of changes

Added zfind as a new package to nixpkgs.

zfind allows you to search for files, including inside tar, zip, 7z and rar archives. It makes finding files easy with a filter syntax that is similar to an SQL-WHERE clause.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@matteo-pacini matteo-pacini self-requested a review June 6, 2024 13:34
Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 317742 run on aarch64-darwin 1

1 package built:
  • zfind

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1720

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1723

pkgs/by-name/zf/zfind/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/zf/zfind/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/zf/zfind/package.nix Outdated Show resolved Hide resolved
@eeedean eeedean changed the title zfind: init at 0.3.0 zfind: init at 0.4.0 Jun 7, 2024
@eeedean
Copy link
Contributor Author

eeedean commented Jun 7, 2024

As I had to touch the commit anyway, I figured, I could also just init at 0.4.0, which has been released on the 6th of June.

Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1744

@eeedean eeedean requested a review from drupol June 14, 2024 10:43
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pass your file through nixfmt-rfc-style.

@eeedean
Copy link
Contributor Author

eeedean commented Jun 14, 2024

Please pass your file through nixfmt-rfc-style.

I did run nix run nixpkgs#nixfmt-rfc-style -- nixfmt pkgs/by-name/zf/zfind/package.nix now. 😸

@drupol drupol merged commit 45dca88 into NixOS:master Jun 14, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants