-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grafana-alloy: init at 1.1.1 #317741
grafana-alloy: init at 1.1.1 #317741
Conversation
I updated this PR, fixed the darwin build by setting I ran some smoketests locally, the web interface comes up and it accepts my old river config (from grafana-agent times), so things are looking fine. I'd be fine to merging this in, but let's give @emilylange some time to also review this. I was planning to continue with a NixOS module in a followup PR, either tomorrow or on the weekend, but no promises ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, @flokli, your grafana-agent: set mainProgram commit reads grafana-agent
, not grafana-alloy
.
You mixed that up.
We should probably just squash all of this into a single commit called
grafana-alloy: init at 1.1.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we could format this with /new package/ with nixfmt-rfc-style
.
Signed-off-by: Vunny Sodhi <[email protected]>
set proxyVendor = true, and re-enable lib.platforms.unix.
FIxed.
I wanna maintain the original authorship, this already had quite some people touching it.
I personally don't think the new formatter is an improvement, and have |
Description of changes
Adding (grafana-)alloy, a rewrite of grafana-agent.
https://github.com/grafana/alloy
https://grafana.com/oss/alloy
Closes #303418
@flokli @emilylange I added you as maintainers as you already maintain grafana-agent and signaled interest in maintaining alloy as well. I hope that's ok!
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.