sandboxfs: remove #317681
Merged
sandboxfs: remove #317681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b29e71
to
67a8ee1
Compare
f6bb2c6
to
e4d2a38
Compare
ff87c1e
to
3e658b4
Compare
Aleksanaa
reviewed
Jun 20, 2024
sandboxfs was an experiment to increase sandboxing performance in bazel,
but it never reached a stable release.
The author of sandboxfs left Google in 2020 and there have been no
updates to it since then.
bazel dropped sandboxfs in the bazel 7 release. To quote their release
notes:
The sandboxfs sandboxing strategy is removed. It hadn't been
maintained for a long time, it didn't work for most users and it was
not consistently faster while being complex to set up. sandboxfs
performance is heavily dependent on the specific setup (setup costs
are lower, but you have to pay a penalty for the use of each input)
and there are scenarios where it is faster and scenarios where it is
slower. Overall it is not worth its weight.
- bazelbuild/bazel@217fafe
3e658b4
to
f13547a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes sandboxfs.
sandboxfs was an experiment to increase sandboxing performance in bazel, but it never reached a stable release.
The author of sandboxfs left Google in 2020 and there have been no updates to it since then.
bazel dropped sandboxfs in October 2023. To quote their release notes:
- bazelbuild/bazel@217fafe
No other packages in nixpkgs depend on sandboxfs.
Gentoo has also dropped sandboxfs from their distribution: https://bugs.gentoo.org/930790
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.