Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.loguru-logging-intercept: init at 0.1.4 #317359

Merged

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jun 5, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Moraxyc
Copy link
Contributor

Moraxyc commented Jun 5, 2024

Thanks for changing!

Now, the commit msg and PR title could be 0.1.4

@Sigmanificient Sigmanificient changed the title loguru-logging-intercept: init at 0.1.4-unstable loguru-logging-intercept: init at 0.1.4 Jun 5, 2024
@Moraxyc
Copy link
Contributor

Moraxyc commented Jun 5, 2024

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:
  • python311Packages.loguru-logging-intercept
  • python311Packages.loguru-logging-intercept.dist
  • python312Packages.loguru-logging-intercept
  • python312Packages.loguru-logging-intercept.dist

Copy link
Contributor

@Moraxyc Moraxyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Sigmanificient Sigmanificient changed the title loguru-logging-intercept: init at 0.1.4 python312Packages.loguru-logging-intercept: init at 0.1.4 Jun 6, 2024
@SuperSandro2000 SuperSandro2000 merged commit c5a8bae into NixOS:master Jun 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants