Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: 28.3.1 -> 28.3.3, 29.4.0 -> 29.4.2, 30.0.6 -> 30.1.1 #317044

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

yayayayaka
Copy link
Member

@yayayayaka yayayayaka commented Jun 3, 2024

Description of changes

Electron 28

Electron 29

Electron 30

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you want to bump electron_30 to 30.1.0 here as well?

@yayayayaka
Copy link
Member Author

Sure, can do.

@yayayayaka yayayayaka changed the title electron: 28.3.1 -> 28.3.3, 29.4.0 -> 29.4.2, 30.0.6 -> 30.0.9 electron: 28.3.1 -> 28.3.3, 29.4.0 -> 29.4.2, 30.0.6 -> 30.1.0 Jun 8, 2024
@yayayayaka yayayayaka changed the title electron: 28.3.1 -> 28.3.3, 29.4.0 -> 29.4.2, 30.0.6 -> 30.1.0 electron: 28.3.1 -> 28.3.3, 29.4.0 -> 29.4.2, 30.0.6 -> 30.1.1 Jun 13, 2024
@emilylange
Copy link
Member

Result of nixpkgs-review pr 317044 run on x86_64-linux 1

7 packages marked as broken and skipped:
  • blockbench
  • deltachat-desktop
  • electron_28
  • electron_28-bin
  • itch
  • lx-music-desktop
  • mattermost-desktop
62 packages built:
  • affine
  • antares
  • bilibili
  • bitwarden-desktop
  • bitwarden-directory-connector
  • breitbandmessung
  • bruno
  • camunda-modeler
  • drawio
  • drawio-headless
  • electron (electron_30)
  • electron-bin (electron_30-bin)
  • electron_29
  • electron_29-bin
  • element-desktop
  • element-desktop-wayland
  • fcast-receiver
  • feishin
  • freetube
  • headset
  • heroic
  • heroic-unwrapped
  • jitsi-meet-electron
  • koodo-reader
  • kuro
  • morgen
  • nix-tour
  • obsidian
  • open-stage-control
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • passky-desktop
  • podman-desktop
  • pritunl-client
  • proton-pass
  • protonmail-desktop
  • python311Packages.mkdocs-drawio-exporter
  • python311Packages.mkdocs-drawio-exporter.dist
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • sharedown
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • teams-for-linux
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • webcord
  • webcord-vencord
  • youtube-music
  • ytdownloader
# git describe --abbrev=40
24.05-pre-87571-ga3ba07a2b6fb2d5374ccad78228b136ca8bd37da

element-desktop runs fine under wayland/sway.

@yayayayaka yayayayaka merged commit 9ae6888 into NixOS:master Jun 14, 2024
31 of 32 checks passed
@yayayayaka yayayayaka deleted the update-electron branch June 14, 2024 07:36
Copy link
Contributor

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-317044-to-release-23.11 origin/release-23.11
cd .worktree/backport-317044-to-release-23.11
git switch --create backport-317044-to-release-23.11
git cherry-pick -x 7f0243c8fe6a8dbf11cc79edf6b890506d2646a7 c391e6c7e929b5333f2fe2ad4f9591a96b032096 df4ae42c07540bfdeea1243052707e02979eb556 290687fa3ad8a922886d890b6f33c148a16a21fe 8fae4e54b1661fd1c4859cb82eeb75e66ba635e9

Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants