python312Packages.prometheus-fastapi-instrumentator: init at 7.0.0 #317014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcdarwin
force-pushed
the
init-python3-prometheus-fastapi-instrumentator
branch
from
223c421
to
21a7ade
Compare
bcdarwin
force-pushed
the
init-python3-prometheus-fastapi-instrumentator
branch
from
21a7ade
to
418e938
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4111 |
bcdarwin
force-pushed
the
init-python3-prometheus-fastapi-instrumentator
branch
from
418e938
to
d2d7e35
Compare
bcdarwin
force-pushed
the
init-python3-prometheus-fastapi-instrumentator
branch
from
d2d7e35
to
fdcb3bc
Compare
dani0854
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Reviewed points
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package builds on x86_64-linux
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.platformsis set -
meta.maintainersis set - source is fetched using the appropriate function
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1761 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add Prometheus FastAPI instrumentator.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.