Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

armagetronad: update 0.4; fix possible problem in installCheckPhase #316823

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Jun 3, 2024

Description of changes

Fixing ZHF issues: https://hydra.nixos.org/build/260923940/nixlog/4

Build stops on installCheckPhase on Hydra but succeeds locally(???). Attempting to fix it. "Works on my machine" isn't supposed to happen here...

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@numinit numinit added the backport release-24.05 Backport PR automatically label Jun 3, 2024
@numinit numinit changed the title armagetronad: fix installCheckPhase on hydra armagetronad: update 0.4; fix installCheckPhase on hydra Jun 3, 2024
@numinit numinit force-pushed the armagetronad-fix-install-check branch from 335ad89 to 2e47843 Compare June 3, 2024 07:06
@numinit numinit changed the title armagetronad: update 0.4; fix installCheckPhase on hydra armagetronad: update 0.4; fix possible problem in installCheckPhase Jun 3, 2024
@numinit numinit marked this pull request as ready for review June 3, 2024 17:59
@numinit
Copy link
Contributor Author

numinit commented Jun 3, 2024

@ofborg build armagetronad armagetronad-dedicated armagetronad.passthru.tests

@numinit numinit force-pushed the armagetronad-fix-install-check branch from 8d52244 to 060b673 Compare June 16, 2024 01:57
@numinit numinit added 0.kind: ZHF Fixes Fixes during the ZHF campaign 0.kind: build failure labels Jun 16, 2024
@numinit
Copy link
Contributor Author

numinit commented Jun 16, 2024

Should be ready. Rebased.

@numinit numinit force-pushed the armagetronad-fix-install-check branch from 060b673 to b0ef59b Compare June 23, 2024 01:35
@numinit
Copy link
Contributor Author

numinit commented Jun 23, 2024

Rebased again against changes to NixOS tests.

@numinit numinit requested a review from tomberek June 24, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant