Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

picom-pijulius: 8.2-unstable-2024-04-30 -> 8.2-unstable-2024-06-13 #316783

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

YvesStraten
Copy link
Contributor

@YvesStraten YvesStraten commented Jun 3, 2024

Description of changes

This commit updates picom-pijulius, and adds support for passthru.updateScript

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@YvesStraten YvesStraten changed the title WIP: picom-pijulius: 8.2-unstable-2024-04-30 -> Next-unstable-2024-06-01 WIP: picom-pijulius: 8.2-unstable-2024-04-30 -> Next-unstable-2024-06-06 Jun 7, 2024
@YvesStraten YvesStraten changed the title WIP: picom-pijulius: 8.2-unstable-2024-04-30 -> Next-unstable-2024-06-06 picom-pijulius: 8.2-unstable-2024-04-30 -> Next-unstable-2024-06-06 Jun 7, 2024
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I have left some review comments for you to check.

pkgs/by-name/pi/picom-pijulius/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/picom-pijulius/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/picom-pijulius/package.nix Outdated Show resolved Hide resolved
@YvesStraten
Copy link
Contributor Author

Thank you very much for your comments, I'll check what's up with nix-update later

@YvesStraten
Copy link
Contributor Author

YvesStraten commented Jun 8, 2024

I have tried, and I am very close, but unfortunately, without regex, unstableGitUpdater fails, with the regex, the name is replaced with a starting 0. If you could could help me with this that would be highly appreciated, thank you very much 馃檹

@YvesStraten YvesStraten changed the title picom-pijulius: 8.2-unstable-2024-04-30 -> Next-unstable-2024-06-06 picom-pijulius: 8.2-unstable-2024-04-30 -> next-unstable-2024-06-13 Jun 17, 2024
@YvesStraten YvesStraten changed the title picom-pijulius: 8.2-unstable-2024-04-30 -> next-unstable-2024-06-13 picom-pijulius: 8.2-unstable-2024-04-30 -> 8.2-unstable-2024-06-13 Jun 17, 2024
@YvesStraten YvesStraten force-pushed the update/picom-pijulius branch 5 times, most recently from ef9c116 to 069972f Compare June 17, 2024 01:51
@heisfer
Copy link
Contributor

heisfer commented Jun 17, 2024

@JohnRTitor shouldn't this be 0-unstable-x.x.x instead for Auto Updater work correctly?
Also, versioning schema was last used 4聽years ago, but repo is still actively being maintained, so I think it should be redundant.

  passthru.updateScript = unstableGitUpdater {
    branch = "next";
    hardcodeZeroVersion = true;
  };

I also found this package: https://github.com/NixOS/nixpkgs/commits/master/pkgs/development/libraries/cegui/default.nix for the reference.

@JohnRTitor
Copy link
Contributor

JohnRTitor commented Jun 17, 2024

The last "released" tag is just vNext and the tag before that was 8.2. I do not think if it would be appropriate to hardcode "0" as the version prefix.

8.2 could work. And we could use tagConverter to convert the tag appropriately?

, tagConverter ? null # A command to convert more complex tag formats. It receives the git tag via stdin and should convert it into x.y.z format to stdout

@YvesStraten
Copy link
Contributor Author

I don't know how to use it, but I will look into it

@YvesStraten
Copy link
Contributor Author

Has been done @JohnRTitor, please review whether the commits are fine, thank you in advance

@JohnRTitor JohnRTitor dismissed their stale review June 20, 2024 12:20

changes addressed

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

update script tested and works

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 316783 run on x86_64-linux 1

1 package built:
  • picom-pijulius

@JohnRTitor JohnRTitor merged commit cb3cfc2 into NixOS:master Jun 20, 2024
24 checks passed
@YvesStraten YvesStraten deleted the update/picom-pijulius branch June 22, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants