nuv: init at 3.0.1-beta.2405292059 #316731
Conversation
maintainers/maintainer-list.nix
Outdated
| ```shell | ||
| gpg --fingerprint <email> | head -n 2 | ||
| ``` | ||
| To get the required PGP/GPG values for a key run |
There was a problem hiding this comment.
What are you doing here??
There was a problem hiding this comment.
Sorry, @AndersonTorres :( Don't know why that happened. Will fix ASAP
|
Hello @AndersonTorres ! Is there any problem preventing the merge? |
|
Put the attributes in the same order of this guide first. |
There was a problem hiding this comment.
Finally, squash all commits:
- One for each new contributor, with the message
maintainers: add <maintainer> - One for the package itself,
nuv: init at 3.0.1-beta.2405292059
reports from review tool:
{
"blacklisted": [],
"broken": [],
"built": [
"nuv"
],
"extra-nixpkgs-config": null,
"failed": [],
"non-existent": [],
"pr": 316731,
"system": "x86_64-linux",
"tests": []
}
|
Thank you @AndersonTorres ! |
|
Hello @AndersonTorres is there something that prevent this PR from being merged? |
|
Yes. Namely, a committer :) |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1747 |
|
Could @sciabarracom verify consent to being added to the maintainer list? |
|
Yes I confirm I want to be added |
|
Hello @h7x4, @sciabarracom confirmed. Let me know if something more is needed. Regards |
|
@d4rkstar are you familiar with the git operations you need to squash the commits? Feel free to ask if you're unsure |
Yes, and it's usually a trivial task but for some reason the squash ends up with a merge from master. :( I'm doing something the wrong way |
|
Can you do In the meanwhile, I'll temporarily mark the PR as draft in case something goes wrong, so we avoid mass pinging people. |
{
"blacklisted": [],
"broken": [],
"built": [
"nuv"
],
"extra-nixpkgs-config": null,
"failed": [],
"non-existent": [],
"pr": 316731,
"system": "x86_64-linux",
"tests": []
}
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.