Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top-level/aliases: Clean up outdated Nix aliases #316664

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jun 2, 2024

Description of changes

  • Nix 2.6 was removed on 2022-12-28: 1723477
  • Nix 2.4 and 2.5 were removed on 2022-07-14: b2eea05
  • nixVersions.unstable throws but it does not mention the alias: 2b4e18f

https://discourse.nixos.org/t/rant-finding-errors-in-module-configs-after-incompatible-upgrades-is-dreadful/46375

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- Nix 2.6 was removed on 2022-12-28: 1723477
- Nix 2.4 and 2.5 were removed on 2022-07-14: b2eea05
- `nixVersions.unstable` throws but it does not mention the alias: 2b4e18f
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rant-finding-errors-in-module-configs-after-incompatible-upgrades-is-dreadful/46375/3

@jtojnar
Copy link
Member Author

jtojnar commented Jun 2, 2024

Ideally, we would also convert nixFlakes, nixStable and nix_2_3 to throw but that is not backportable.

@jtojnar jtojnar added the backport release-24.05 Backport PR automatically label Jun 2, 2024
@jtojnar jtojnar merged commit d599897 into NixOS:master Jun 18, 2024
22 checks passed
@jtojnar jtojnar deleted the double-alias branch June 18, 2024 20:45
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants