unstableGitUpdater: Remove bitrotten comment about hardcodeZeroVersion on tag-less projects #316264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on tag-less projects The behaviour this refers to was changed since then, unstableGitUpdater now automatically falls back to 0 when there are no previous tags.
12 tasks
JohnRTitor
added a commit
to JohnRTitor/nixpkgs
that referenced
this pull request
Jun 1, 2024
move to finalAttrs use `lib.` explicitly format with nixfmt-rfc-style remove hardcodeZeroVersion per NixOS#316264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The behaviour this refers to was changed since then, unstableGitUpdater now automatically falls back to 0 when there are no previous tags.
#280501, 3cd4a35
To avoid people using
hardcodeZeroVersion = truesolely because there are no previous releases, drop this bitrotten bit of the comment.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.