otree: init at 0.2.0 #316252
otree: init at 0.2.0 #316252
Conversation
0x61nas
force-pushed
the
by-name/otree
branch
2 times, most recently
from
bff636b
to
ad6dd98
Compare
There was a problem hiding this comment.
Thanks for this, @0x61nas! 😃 👍
Please find below a few comments and suggestions, mainly to add support for building on darwin.
Is there any way we could remove the dependency on git for building? Upstream seems to offer BUILD_OTREE_WITH_GIT_INFO and CARGO_PKG_VERSION could those be helpful here?
pkgs/by-name/ot/otree/package.nix
Outdated
| repo = "otree"; | ||
| rev = "v${version}"; | ||
| hash = "sha256-ukKlypGY0+xsci/loAnf0Sz5K+82gVzkb+KnZ139cIA="; | ||
| leaveDotGit = true; # needed by build.rs |
There was a problem hiding this comment.
ℹ️ I was able to successfully build on aarch64-darwin without this.
in v0.1.0 i dont think so
oh, that's would help ofc, i think with this we can remove |
|
Maybe a TODO comment in the package regarding removal of the |
|
good idea |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4071 |
Co-authored-by: Alexis Hildebrandt <[email protected]>
There was a problem hiding this comment.
How fortunate, that version 0.2.0 was released while this PR is still under review and leaveDotGit and git in nativeBuildInputs are no longer necessary 🥳
If you wanted to go above and beyond with this PR, please consider formatting it using:
nix run github:NixOS/nixfmt -- pkgs/by-name/ot/otree/package.nix
|
@0x61nas any idea what could cause the ofborg-eval check failure? |
at the first, i thought that it was because of our (hacky) featching, but now i am not sure why |
|
Format using nixfmt-rfc-style |
Description of changes
addition otree package, which is a command line tool to view objects (json/yaml/toml) in TUI tree widget
try the package
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.